[FIX] Use correct shift between start and end in UpdateSize #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old value was correctly documented to be 1, but wrongly set to 0. This lead to the UpdateSize being zero, because parameters from the same iteration would be used as start/end points in the computation.
f-dangel
force-pushed
the
bug-fix-update-size
branch
from
23c38cd
to
3d5ad7a
Compare
2 tasks
f-dangel
added a commit
that referenced
this pull request
Apr 30, 2021
* [REP] Ignore build files of doc * [DOC] Add pip install cmd to example Highlight the need for the utils file * [REP] Ignore logfiles (from running examples) * [FIX] Move examples utilites out of subdir * [DOC] Add install instruction for DeepOBS * [DOC] Make pip install very prominent * [DOC] Remove sphinx copybutton due to issue Highlighted lines have an extra line break, probably related to this: executablebooks/sphinx-copybutton#118 If there is a fix, we can enable it again. * [DOC] Remove sphinx copybutton due to issue Highlighted lines have an extra line break, probably related to this: executablebooks/sphinx-copybutton#118 If there is a fix, we can enable it again. * [FIX] Output to terminal when plotting * [FIX] Ignore irrelevant torch warning for examples * [DOC] Document terminal output in examples * [TST] Define MPLBACKEND for tests * [FIX] More meaningful plotting msg * [DOC] Add a blocking plot after training * [FIX] Move Curvature plots slighty right * [FIX] Round histograms ticks * [FIX] Format ticks * [DOC] Update preview example 01 * [DOC] Make example 02 longer * [DOC] Run DeepOBS Example for 50 epochs * [DOC] Add quickstart page [WIP] * [FIX] Use correct shift between start and end in UpdateSize (#3) The old value was correctly documented to be 1, but wrongly set to 0. This lead to the UpdateSize being zero, because parameters from the same iteration would be used as start/end points in the computation. * [DOC] Replace personal output dir * [DOC] Update Backobs install command * [DOC] Install DeepOBS from development * [DOC] Put utility file reminder in note block * [DOC] Add download button for script * [DOC] Add download button to script * [DOC] Remove quickstart page (for now) Co-authored-by: Felix Dangel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old value was correctly documented to be 1, but wrongly set to 0.
This lead to the UpdateSize being zero, because parameters from the same
iteration would be used as start/end points in the computation.